Repair_settings.php - 1.1 compat logic vs php 7.x

[sbulen]

I think we're seeing some last stragglers finally moving off of 1.x... Some moving to new hosts.

One problem seen is if they restore files & db onto a new host, they need to run repair_settings.php to get the settings pointing to the new locations. Although repair_settings.php has a 1.x compatibility mode, that mode assumes mysql (not mysqli) calls. If that host is pushing folks to php7, those mysql calls won't work (mysql_connect doesn't exist).

To fix, there are a few options -

• add mysqli support to the 1.x compatibility logic
• build a legacy 1.x-only version of repair_settings.php
• support upgrading to the new code before running repair_settings.php (which doesn't work today, reason unknown as the error reporting is erroring out...)

Originally reported here: https://www.simplemachines.org/community/index.php?topic=561873.0

[sbulen]

Another issue with 1.1 - if db name or prefix are wrong, you error out (any php version):