Revamp fix_packages - Githubissues

SimpleMachines / tools

Tools for SMF: useful scripts, install/repair and others.

21 stars 33 forks source link

Revamp fix_packages #63

Closed jdarwood007 closed 1 year ago

jdarwood007 commented 2 years ago

Fixes #57 Fixes #62

jdarwood007 commented 2 years ago

FYI I only tested this on 2.0 and 2.1. Didn't test 1.x

sbulen commented 1 year ago

I don't recall seeing this request for review earlier. Sorry about that.

I'll take a look. I am not actually familiar with this tool or what it does... The one time I tried to figure it out it didn't work with php 8...

I thought this wasn't necessary for 2.1??? And, to be honest, I don't want to spend time on anything specific to 2.0, which is in security fix only mode. I'd like to focus all bandwidth on 2.1 going forward.

DiegoAndresCortes commented 1 year ago

Some users were trying to use it on 2.1 since it’s valid, but reported it as faulty using php 8 Perhaps Sleepy forgot about this one too.

sbulen commented 1 year ago

Can someone tell me what this is supposed to do? 😆

Is there a description anywhere? It's not in the code...

I think it's supposed to help you:

Flag packages as installed or uninstalled
Activate or inactivate integration hooks

Anything else?

I actually don't have any 2.0 environments to test anymore... I thought I was done with 2.0... I'm trying to build a 2.0.19 env to test this...

jdarwood007 commented 1 year ago

I believe that is what it was designed to do. Fix a broken package where your forum may not otherwise work.

sbulen commented 1 year ago

OK, just pulled it up & I suspect a problem. I have 5 packages installed in my test environment. When I pull up the old version, it lists the 5 packages. When I pull up the new version, it lists 0 packages. No errors...

Screenshot 1 - old version (php 7.4): old_version

Screenshot 2 - new version (php 8.0): none_show

Screenshot 3 - 5 packages installed in pacman: packages_installed

sbulen commented 1 year ago

There is a definite issue with how it is calling the list builder. The param is not getting passed properly... isInstalled is false, so it's looking for packages with an installed value of 0.

In my simple test, they all have a value of 1, so no packages are returned.

jdarwood007 commented 1 year ago

I will try to get around to it soon as I can.