search

SimpleMobileTools / Simple-App-Launcher

A simple holder for favourite apps for quick & easy app launcher icon management
https://www.simplemobiletools.com
GNU General Public License v3.0
421 stars 160 forks source link

Fix compatibility with latest commons #147

Closed julianfairfax closed 2 years ago

tibbi commented 2 years ago

wtf

julianfairfax commented 2 years ago

... this change allows you to build Simple App Launcher with the latest version of Simple Commons. Otherwise it complains that Int is inferred but it was expecting Long

tibbi commented 2 years ago

and adding a fake license is the way to fix it? Really?

julianfairfax commented 2 years ago

and adding a fake license is the way to fix it? Really?

I mean, yes? I didn't know how exactly you were going to do it, but this is what I found in other Simple Mobile Tools apps (in the Calculator specifically), and it actually builds this way.

It seems with the new commons version, 0 isn't an acceptable way to say there are no licenses. I don't know what is, but it seems that's what should be done then as no licenses are supposed to be included.

tibbi commented 2 years ago

Just use 0L...

julianfairfax commented 2 years ago

That does work... sorry for my stupidity. I changed it in my branch but it seems this pull request didn't pick up on it. Nevermind about then.

I'm not an Android developer (clearly), so I'll stop trying to be