Closed jberggg closed 4 years ago
oh gosh, stick to the code style that is used in the whole app suite, this code looks really strange and hard to read
I guess with
code looks really strange and hard to read
you refer to the Kotlin language features like let
and Collection methods used.
IMHO those features help to make the code less variable-heavy and elegant to avoid null-pointer exceptions as one does not have to override null-check with !!
. I used appropriate names for variables in collection methods and let
statements instead of it
. I placed the logic completely in the helper method to avoid spreading it all over the place. But I understand that this has also a lot to do with personal preference and it was not my goal to change the code style.
I will close the PR. Feel free to transfer some of the logic to your logic to make higher resolution work.
To get all available photo resolution the camera supports, one needs to call
getHighResolutionOutputSizes
on Android SDK 23+ Operating Systems.This fix relates to issue #190