CameraX: Fix capture/preview resolution

[KryptKode]

Changes

• always show the navigation bar
• adjust the preview so the image captured is what the user sees
• add method MySize.isSupported(); current support is for full, 16:9, 4:3 and 1:1 of the highest resolution
• cleanup ImageQualityManager, add a method to get the full-screen resolution which is just the resolution with the largest width
• change the UI to move settings to the top and remove the auto fading
• -add theme attribute android:windowLayoutInDisplayCutoutMode to shortEdges in the theme
• add flags FLAG_LAYOUT_NO_LIMITS to the window flags
• add the top margin to the icons on top, and set it to the statusBarHeight
• add the bottom margin to the icons at the bottom, set it to the navigationBarHeight + view margin
• rearrange the top icons
• use tabs for camera modes

[tibbi]

it behaves way too bad with a notch and the flashlight/resolution pickers dont work like in OnePlus camera at all yet

[tibbi]

1. I dont like that orange background behind the current flash mode and resolution, lets just color the icons orange as they are now
2. lets make the Fullscreen icon taller as it is currently a square, use the square for 1:1, just like at OnePlus camera. If you cannot redraw them, Ill do that later.
3. lets add some fade animations at toggling flashlight or aspect ratio, like in OnePlus camera too. When the available options are shown and hiding.
4. in the app settings if both Purchase Thank You and Use English are hidden, hide the General section label too. Currently I see the General label without having anything in it.

Notch handling and photo/video capturing itself seems to work just fine though, good job on that. Ill do more testing later with other devices etc too.

[tibbi]

did some more tests, it seems to work well with zooming and clicking for changing focus too. We could maybe change the main Capture button to a basic circle and have some click effect there like at OnePlus Camera. The latest Simple Gallery build from github seems to rotate photos captured with the front camera by 90 degrees if deep zoomable images are enabled, maybe you could take a look at it. If deep zooming is disabled, it works well.

[tibbi]

when I was testing the app, toggling front/rear camera, going into the gallery etc and opening other camera apps too, I started getting "An error occurred while obtaining the camera" or so when launching Simple Camera, while opening other camera apps worked. I had to force close Simple Camera to fix it. I cannot reproduce it though, just saying that it can happen.

[tibbi]

top and bottom margins seem to be not set properly after first run, when the permissions are just being granted. Afterwards it works well already. I mean that those top 3 icons are behind the notch and the bottom buttons are behind the navigation bar.

[tibbi]

if I start recording a video and switch to Photo mode without stopping the recording, I get an error that "video recording failed, try using a different resolution". But the actual recorded video is saved properly.

[tibbi]

if I click on the aspect ratio picker and select the currently selected ratio, lets not reload anything to avoid glitches, just close the aspect ratio picker

[tibbi]

I found these 3 on my Android 12, but it will likely happen everywhere.

[tibbi]

the core seems to work well, I reported mostly some UI glitches and improvements. Once you fix the things listed here, Ill merge the PR and Ill create individual tasks for whatever I find so that it is maintainable.

[KryptKode]

I will look into them. Thanks

[tibbi]

you can also update the target and compile SDK version to 33, we wont need 31 anymore

[KryptKode]

Hello @tibbi . Please review. I fixed the issues you highlighted except these ones

1. fix toggling front/rear camera, going into the gallery etc and opening other camera apps shows error
2. fix margins after fresh install

I couldn't reproduce them

[tibbi]

nice, just a couple details.

1. the top items arent properly aligned in my case at opening. Like if you click on the aspect ratio picker and the new options appear, they are positioned a bit lower than the original bar.
2. there is some small left to right animation of the middle 4:3 aspect ratio at extending, when the available aspect ratios show up. I guess it is centered dynamically? Lets place it in the middle instantly. Note that I have 16:9 hidden, guess that is the fullscreen aspect ratio
3. I can never exit the app with the Back button, it is blocked by something. Not even after a fresh launch.

[tibbi]

actually Ill accent the PR as it is getting ridiculously big, will go through the code and tweak some things here and there once you are done with it.

[KryptKode]

2. there is some small left to right animation of the middle 4:3 aspect ratio at extending, when the available aspect ratios show up. I guess it is centered dynamically? Lets place it in the middle instantly. Note that I have 16:9 hidden, guess that is the fullscreen aspect ratio

Yes, it's hidden because the full screen mode is a 16:9