SimpleMobileTools / Simple-Clock

Combination of a beautiful clock with widget, alarm, stopwatch & timer, no ads
https://www.simplemobiletools.com
GNU General Public License v3.0
588 stars 237 forks source link

Vibration fixes #467

Closed rawlin closed 1 year ago

rawlin commented 1 year ago

Fixed issues with vibration in notifications as well as RemiderActivity

tibbi commented 1 year ago

it always vibrates to me on the lockscreen, even if it is disabled and change the audio file to create a new notification channel

rawlin commented 1 year ago

Added post delay for vibrations, and deleting notification channels after the notification is dismissed

tibbi commented 1 year ago

it still always vibrates to me on lockscreen. But if you cannot solve it, Ill just accept it as these issues can be system specific too

rawlin commented 1 year ago

it still always vibrates to me on lockscreen. But if you cannot solve it, Ill just accept it as these issues can be system specific too

Sure @tibbi , I've tested this on 2 of my devices (Samsung Note 9 - Android 9 & Xiaomi Redmi Note 9 - Android 11) and these changes fix it for me

tibbi commented 1 year ago

dont you have some newer Android devices too? Testing it on Android 11 the highest isnt really a good idea

rawlin commented 1 year ago

@tibbi I usually test out features with emulators for the latest SDK versions but I don't believe there is a way to debug vibrations on an emulator so I used a physical device

tibbi commented 1 year ago

right, having Android 11 as the latest device is a pretty big limitation for the project though :/

rawlin commented 1 year ago

I'll install a custom rom of Android 13 if that's the case

tibbi commented 1 year ago

well, you should definitely be using some newer OS for your own sake, so that you are familiar with the latest UI, animations, behaviour etc

rawlin commented 1 year ago

I've tested this on Samsung Note 9 on Android 13, and the vibration is working as expected on the lock screen with these changes

tibbi commented 1 year ago

okay thanks, will see how will it work to the users