SimpleMobileTools / Simple-Clock

Combination of a beautiful clock with widget, alarm, stopwatch & timer, no ads
https://www.simplemobiletools.com
GNU General Public License v3.0
589 stars 235 forks source link

Migrate to viewbinding, kotlin gradle scripts and SDK 34 #487

Closed esensar closed 1 year ago

esensar commented 1 year ago

Changes:

No other changes from these lists affects this app:

tibbi commented 1 year ago

some texts like the tone text at the Alarm tab, Edit alarm isnt centered vertically properly. Also make it a bit higher as the Label below it is too close. Its height in Timer dialog is good, but the text of the notification audio and top timer arent centered either.

tibbi commented 1 year ago

Alarm checkbox and Stopwatch sorting arrow dont change their primary colors properly on resume, it needs an app restart

esensar commented 1 year ago

some texts like the tone text at the Alarm tab, Edit alarm isnt centered vertically properly. Also make it a bit higher as the Label below it is too close. Its height in Timer dialog is good, but the text of the notification audio and top timer arent centered either.

I have updated these now. They should look the same and should be properly centered. Regarding the top timer, not really sure what exactly you mean. It does have more padding on the top side than the bottom, since it is the first item in the list and it has extra padding from the top side of the dialog. Do you want that to be the same as spacing to the next item?

tibbi commented 1 year ago

it is about the timer label itself, not something related to other views or the dialog. The time is slightly above the center line, even compared to the icon next to it. Long press the items to see what I mean. Reminder labels still seem to be slightly higher, not centered.

tibbi commented 1 year ago

should be good now, thanks

tibbi commented 1 year ago

adding a new alarm doesnt refresh the list, it isnt visible. Pressing Sort at alarms sometimes doesnt show the sorting dialog.

esensar commented 1 year ago

adding a new alarm doesnt refresh the list, it isnt visible. Pressing Sort at alarms sometimes doesnt show the sorting dialog.

I found the issue related to refreshing and opened a PR: https://github.com/SimpleMobileTools/Simple-Clock/pull/494 I am not sure what is wrong with sorting, I haven't been able to reproduce it.

tibbi commented 1 year ago

sorting breaks after rotating the device

esensar commented 1 year ago

sorting breaks after rotating the device

Yeah, just managed to reproduce it that way. Looks like an issue in the ViewPagerAdapter. I will fix it.