SimpleMobileTools / Simple-Clock

Combination of a beautiful clock with widget, alarm, stopwatch & timer, no ads
https://www.simplemobiletools.com
GNU General Public License v3.0
586 stars 238 forks source link

Try reading stored timer in both obfuscated and non-obfuscated state #528

Closed esensar closed 11 months ago

tibbi commented 11 months ago

have you reproduced the issue? Was it obfuscated before and not anymore?

esensar commented 11 months ago

Yeah, in all previous versions it is stored obfuscated and due to some changes between the versions, the obfuscated names have changed for TimerState. Luckily, it is always Idle when stored in that field, so I just set it to default to Idle when reading from obfuscated state. Every new version will now write the Timer without obfuscation and it should be much easier to handle upgrades.

tibbi commented 11 months ago

alright thanks, hope it will work well. We want to store such stuff unobfuscated indeed

esensar commented 11 months ago

Alarm is still stored obfuscated. Should I do the same for it too?

tibbi commented 11 months ago

yeah, lets unobfuscate it, but properly handle updates too