SimpleMobileTools / Simple-Contacts

Easy and quick contact management with no ads, handles groups and favorites too.
https://www.simplemobiletools.com
GNU General Public License v3.0
800 stars 259 forks source link

Crashes when using alphabetic quick scroller #641

Open Gitoffthelawn opened 3 years ago

Gitoffthelawn commented 3 years ago

Thank you for the wonderful apps.

I tried Simple Contacts v6.13.1 for the first time on an API 24 device.

When I tried scrolling using the alphabetic quick scroller on the right-hand side, Simple Contacts would frequently crash. It happened more often when performing large position changes by dragging from the very top or bottom of the alphabetic quick scroller.

Reading the reviews, I see others are experiencing the same issue.

Unfortunately, for now, I decided it best to uninstall Simple Contacts, but I look forward to trying it again once this issue is resolved.

Thank you again. :)

tibbi commented 3 years ago

Hey, not sure where have you seen others mentioning it, you are the first one Im aware of. How many contacts do you have?

Gitoffthelawn commented 3 years ago

I have about 500 contacts.

I tested the F-Droid version, if that matters.

Gitoffthelawn commented 3 years ago

I just thought of something that could be relevant. To improve sorting, I have several contacts whose last name / surname begin with non-alphanumeric characters.

For example, I have a few that begin with a plus sign (+), and others that begin with one or more double chevrons (see https://www.fileformat.info/info/unicode/char/00bb/index.htm).

Gitoffthelawn commented 3 years ago

@tibbi Here is more information regarding testing I have completed for you:

  1. I tried the new Simple Contacts v6.13.2, and it crashes in the same situation as well.
  2. I tried the new Simple Dialer v5.6.0, and it crashes in the same situation as well.
  3. I renamed all contacts that begin with non-alphanumeric characters, and retested items 1 and 2 above. Both apps still crash consistently.
  4. I tried generating a 100% reproducible case in which both the above apps will crash. I had success isolating a 100% case: Drag from the letter A to the letter M, and then back up the letter A. Both apps crash 100% of the time.
tibbi commented 3 years ago

well you havent found out the reason of the crash yet. It obviously doesnt crash if I drag to M.

Gitoffthelawn commented 3 years ago

well you havent found out the reason of the crash yet

I'll leave that to you. ;) No other applications I've tested besides Simple Contacts and Simple Dialer have that issue. Also, both Simple Contacts and Simple Dialer crash using the same simple procedure (described above), so I think it's safe to say it's a bug in your apps.

It obviously doesnt crash if I drag to M.

Have you tried dragging from A to M and then back up to A as previously described?

tibbi commented 3 years ago

Sure. There must be some weird character, or some other thing breaking the app in one of those contacts.

Gitoffthelawn commented 3 years ago

I did initially have several contacts beginning with non-alphanumeric characters, but I deleted the non-alphanumeric characters before testing again. Those follow-up tests all still crashed every time.

If you like, you can also test my original setup by creating contacts that begin with a plus sign (+), and others that begin with one or more double chevrons (see https://www.fileformat.info/info/unicode/char/00bb/index.htm). All such contacts are valid in Android.

Gitoffthelawn commented 3 years ago

Just an update: Tested again with v6.14.3. Still crashes.