search

SimpleMobileTools / Simple-File-Manager

Easy app for managing your files without ads, respecting your privacy & security
https://www.simplemobiletools.com
GNU General Public License v3.0
1.51k stars 385 forks source link

Add fullscreen toggle in PDF Viewer #592

Closed naveensingh closed 2 years ago

naveensingh commented 2 years ago

Full-screen toggle on touch:

https://user-images.githubusercontent.com/36371707/171912365-6bf78141-6f82-4da1-8893-b2638c753599.mp4

The pdf viewer library layout glitches (incorrect height, y position) when the parent is resized hence the hacky approach to resize the view.

Not yet sure what's the exact source of this bug

tibbi commented 2 years ago

this feels too glitchy, try making it with the fullscreen theme like galleries fullscreen view works, we can also use the top gradient shadow over the status and actionbar

naveensingh commented 2 years ago

Like this?

https://user-images.githubusercontent.com/36371707/172779788-844eb589-3ca1-416a-8aa4-cfeace77d623.mp4

I think the gradient can be a little more darker & it's height can be increased (more than statusbar + action bar)