search

SimpleMobileTools / Simple-File-Manager

Easy app for managing your files without ads, respecting your privacy & security
https://www.simplemobiletools.com
GNU General Public License v3.0
1.51k stars 383 forks source link

Feat/improve PDF Viewer #690

Closed ismailnurudeen closed 1 year ago

tibbi commented 1 year ago

no need to complicate the app with modules, add the viewer just as a folder

tibbi commented 1 year ago

that scrolling is really wild, sometimes I just move my finger a bit and it scrolls multiple pages. And lets not snap to the top of the pages. This whole PR has a lot more code than I think it would need :/ The scrollbar dragging at the side is misbehaving too, it just changes the center of the screen instead of actually scrolling full pages, like at scrolling in a gallery or so. Reproducing the previous behaviour before removing the pdf viewer with the vulnerability would be the best, it has been removed at https://github.com/SimpleMobileTools/Simple-File-Manager/commit/ab47bcadbe2807b3aec7c11ce11bb989c58ba35c

ismailnurudeen commented 1 year ago

that scrolling is really wild, sometimes I just move my finger a bit and it scrolls multiple pages. And lets not snap to the top of the pages. This whole PR has a lot more code than I think it would need :/ The scrollbar dragging at the side is misbehaving too, it just changes the center of the screen instead of actually scrolling full pages, like at scrolling in a gallery or so. Reproducing the previous behaviour before removing the pdf viewer with the vulnerability would be the best, it has been removed at ab47bca

The behaviour of the scrollbar at the side is intentional, I added a snapping behaviour to the RecyclerView and I can remove it to make it more fluid.

I will look into the attached PR now.

tibbi commented 1 year ago

it still scrolls just by changing the center of the screen, doesnt scroll actual pages like at casual listviews