SimpleMobileTools / Simple-File-Manager

Easy app for managing your files without ads, respecting your privacy & security
https://www.simplemobiletools.com
GNU General Public License v3.0
1.49k stars 379 forks source link

Add support for decompressing password protected zips #720

Closed esensar closed 1 year ago

esensar commented 1 year ago

This includes Zip4j library which supports password protected ZIP archives and replaces default zip library in DecompressActivity.

NOTE: This does not cover decompression of multiple ZIPs, since I am not completely sure what UX we would want in that case.

TODO

tibbi commented 1 year ago

no need to cover decompressing multiple files for this initial implementation. Lets just go step by step as always. If you detect multiple password protected zips, just shown the An unknown error occurred.

tibbi commented 1 year ago

or lets show Wrong password instead, to at least give the user a hint about what is wrong

tibbi commented 1 year ago

lets replace "Error: Incorrect password" with just "Incorrect password"

esensar commented 1 year ago

lets replace "Error: Incorrect password" with just "Incorrect password"

Should the same be done for PDFs then?

tibbi commented 1 year ago

yeah, lets keep it human, not that robotic

tibbi commented 1 year ago

okay thanks, should be good now