SimpleMobileTools / Simple-File-Manager

Easy app for managing your files without ads, respecting your privacy & security
https://www.simplemobiletools.com
GNU General Public License v3.0
1.49k stars 379 forks source link

Add support for creating password protected zips #721

Closed esensar closed 1 year ago

esensar commented 1 year ago

This one made sense to add since we were adding support for opening password protected ZIPs and the library that was included in that PR (https://github.com/SimpleMobileTools/Simple-File-Manager/pull/720) has that capability already, so it was pretty simple to add.

TODO

esensar commented 1 year ago

I have updated the strings and also added an eye icon for password preview when compressing. If it looks okay, I just need to merge the commons PR (https://github.com/SimpleMobileTools/Simple-Commons/pull/1740) and then update the ref on this PR.

tibbi commented 1 year ago

the eye icon isnt visible in light theme

esensar commented 1 year ago

I have opened up a PR in Simple-Commons to resolve that: https://github.com/SimpleMobileTools/Simple-Commons/pull/1742

tibbi commented 1 year ago

alright thanks, that seems to work just fine