search

SimpleMobileTools / Simple-Gallery

A premium app for managing and editing your photos, videos, GIFs without ads
https://www.simplemobiletools.com
GNU General Public License v3.0
3.6k stars 757 forks source link

[Feature Request] Swipe only through search results #1279

Open floppyD opened 5 years ago

floppyD commented 5 years ago

Like when I search ".webm", the search will return all files I have with this extension, but after opening a file and swiping, it doesn't swipe to the next search result, which is the desired behavior, instead it swipes to the next file on the folder. Also, after swiping and pressing back, the search results disappear, returning to the folder view.

privatmamtora commented 5 years ago

Can this please be split into 2 issues?

  1. [Feature Request] Swipe through search results
  2. [Bug] After selecting an item from search and pressing back, the folder when the search began is shown. If proper order is supposed to be maintained, then back should really be "back" Correct order: "Folder View" > Select "Search" > "Search Results" > Select "item" > Press "Back" > "Search Results" > Press "Back" > "Folder View" Current order: "Folder View" > Select "Search" > "Search Results" > Select "item" > Press "Back" > "Folder View"
KnIfER commented 5 years ago

As for the bug, I have created an PR !

Jeder321 commented 3 years ago

Anything changed since last time? This feature is rather crucial to me because I work on big folders with lots of files I distinguish by using a common word, and so far I found one file explorer that lets me view search results like a gallery, however I'd prefer having it in one app.

tibbi commented 3 years ago

not really, nothing changed. It would need a new setting item as swiping through search results definitely isnt always the expected behaviour.

Eskuero commented 2 years ago

+1 for this feature, many times i give files names as tags and would really like to be able to swipe between then search results rather than the whole folder.

saefthe commented 2 years ago

مرحبا شكرا لكم لا اقبل بحذف اي ملف او مقطع او صور او ملف صوت

Saef

في الثلاثاء، ١٩ تموز ٢٠٢٢, ٢:٥١ ص Óliver García Albertos < @.***> كتب:

+1 for this feature, many times i give files names as tags and would really like to be able to swipe between then search results rather than the whole folder.

— Reply to this email directly, view it on GitHub https://github.com/SimpleMobileTools/Simple-Gallery/issues/1279#issuecomment-1188447488, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWI53YRBFOFRBPWKQNL6RQTVUXUZPANCNFSM4GZCX6SQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

privatmamtora commented 2 years ago

@tibbi Depends on how you phrase it, it might actually be expected. Currently when a user is "viewing" an image, users can swipe left and right, to go to the previous or next image from the "Previous View" (A Folder view) Why shouldn't the same behavior not happen when the previous view is a "Search Results" view?

The fact that swiping an image from search results, shows "other" images, not in the search results, would be the "unexpected behavior" (Whenever it happens to me, I go "wait this wasn't in the results")

An example scenario is if I search for "Astrophotography", view an image, start swiping and suddenly I have random non Astrophotography images showing up from a folder.