SimpleMobileTools / Simple-Gallery

A premium app for managing and editing your photos, videos, GIFs without ads
https://www.simplemobiletools.com
GNU General Public License v3.0
3.6k stars 758 forks source link

Editing PNG images (i.e. screenshots) produces images with jagged edges and washed out colors #2349

Open kaoneko opened 2 years ago

kaoneko commented 2 years ago

Play Store release 6.22.0, also occurs with 6.22.3. Running on a Google Pixel 4a with stock Android 11 ROM.

Original screenshot: Screenshot_20220210-112032

Edited screenshot: Screenshot_20220210-112032_edited

It doesn't seem to matter what kind of editing you do, e.g. adding a sticker, draw a line, add some text, apply a filter.

These closed issues also describe this behaviour: Large png images get distorted in editor #1748 Editing image and exporting it produces low quality image #1762

(They don't mention the colors, but you can see it in the example images.)

Both were marked as duplicates of: Poor image quality for cropped image #1744

Which was closed two years ago with the remark should be fixed in 6.13.0 released soon.

Is this a regression?

MK73DS commented 2 years ago

I'm experiencing the same issue, using Play Store v6.22.0 Pro. First image is a screenshot cropped on my PC using GIMP, second image is a screenshot cropped via the app. The quality is hugely inferior, and the colors are also off. Screenshot_20220510-133333 Screenshot_20220510-133333_1

This seems to happen only when editing png files, I didn't encounter the issue with jpg files. Also, sometimes the jagged edges are less noticeable depending on the cropping size and aspect ratio, but the color is always off. See the following picture, the edges are more or less right but still not as good as the original image. Note that I'm only cropping the image, no scaling is involved, therefore there shouldn't be artifacts. Screenshot_20220510-133333_2

It is quite annoying since it makes small text hard to read, therefore I need to use another photo editor app just to crop my screenshots before sending them.

lipici commented 2 years ago

Same issue at me with proprietary apk, with foss version its ok Also, dosent matter if is png or not, its the same for every picture extension, washed out. Last version at moment of posting.

lipici commented 2 years ago

Screenshot_20220526-170134_1 Screenshot_20220526-170134

Can be resolved this bug ?

tp0 commented 1 year ago

This must be a problem in the PhotoEditor SDK. The Github page links to this (demo) app on Play and it has the same issue with png files.

The Github page offers no way report issues so I guess that's handled via their customer support for license owners. Perhaps leaving a Play review might lead to some attention.

adarsh1001 commented 1 year ago

Issue reproducible on the latest 6.25.5 Pro as well, jagged lines after cropping a PNG.

kaoneko commented 1 year ago

I just checked and this issue still exists in the current version of Simple Gallery Pro. I just don't understand how this doesn't get prioritized, it seems quite severe to me... @tibbi? I've switched to Google Photos for basic editing since opening this issue, which luckily can be invoked from within Simple Gallery, but I wish it wasn't necessary. I can surely see people ditching Simple Gallery altogether because of this issue.

The fact that it only seems to affect screenshots (PNG files) maybe makes it less severe, but I for one don't trust the editor with my photos anymore either now that I know what it does to screenshots.

Asiaboy89 commented 10 months ago

Can confirm this behaviour, but this issue was not always present, only after updating the app to a newer version 1,5 years ago or so.

I'm working often with screenshots (PNGs) and small texts within the screenshots and after adding some comments/text by myself via the editor, the screenshot is noticably worse than before. When I do this 3 or 4 times with the same screenshot (means: adding text, saving photo, adding text, saving, etc.), the content of the screenshot is barely readable.

Please fix that, because it was not always like this.

Example: Original original

original_1 original_1_1 original_1_1_1