SimpleMobileTools / Simple-Keyboard

Easy keyboard for inserting all kinds of texts, special characters and numbers.
https://www.simplemobiletools.com
GNU General Public License v3.0
326 stars 111 forks source link

Sentences capitalization implemented #170

Closed Merkost closed 1 year ago

Merkost commented 1 year ago

48

Created some todos for the nearest future

Merkost commented 1 year ago

@tibbi all done here

tibbi commented 1 year ago

guess we should change "capitalise" to "capitalize" everywhere including the string I created, that seems to be the proper variant

Merkost commented 1 year ago

guess we should change "capitalise" to "capitalize" everywhere including the string I created, that seems to be the proper variant

It really depends on what type of English are we using. For UK it's ‘s’, for US it's ‘z’

Merkost commented 1 year ago

@tibbi, I have refactored the code a lot. Looks more clear than before.

tibbi commented 1 year ago

lets change the default value to True, that is the expected behaviour. However, the toggle doesnt seem to work properly. Try toggling it like 2 times and resuming to the previous screen, writing a dot and space, it wont toggle the behaviour properly and it will always behave as if the toggle was on.

Merkost commented 1 year ago

@tibbi Auto capitalization based on editorInfo is off if capitalization setting in the keyboard is disabled

tibbi commented 1 year ago

alright thanks, should work well I guess :)

tibbi commented 1 year ago

the check enabled seems to cause uppercase letters at inserting passwords too, that might not be the expected behaviour. Check how does Google behave please, Samsung and Microsoft keyboards use lowercase for starting passwords.