SimpleMobileTools / Simple-Keyboard

Easy keyboard for inserting all kinds of texts, special characters and numbers.
https://www.simplemobiletools.com
GNU General Public License v3.0
326 stars 111 forks source link

Add autofill integration to the keyboard #214

Closed esensar closed 1 year ago

esensar commented 1 year ago

This closes #199

esensar commented 1 year ago

I have recorded a simple demonstration of the implementation.

https://github.com/SimpleMobileTools/Simple-Keyboard/assets/2764831/920a001d-a9d8-4db4-9110-9d5e2ac9e9e1

There are some things that I haven't implemented, since I am not sure what UX we are aiming for exactly:

tibbi commented 1 year ago

how to reproduce this? What should I do to see the autofill values?

esensar commented 1 year ago

They should appear automatically for the last 2 lines in that included sample screen, but before that you need to have an autofill service configured in your system settings. In my case it is Bitwarden application, but there should be the default Google service I think. If you have it set up, something should pop up.

It is also possible that you have no values that can be autofilled. You can then manually add some value in your autofill service to test with this. With Google it is done through Passwords & Accounts in system settings. From there it is possible to add a new password and select this application for it.

tibbi commented 1 year ago

lets center everything horizontally, even clipboard is moved at the side now

esensar commented 1 year ago

lets center everything horizontally, even clipboard is moved at the side now

Should it look like before when there are no suggestions, and move it to the side like it is now only when we add autofill suggestions? Because I guess we would need to have some kind of an indication to the users that they have other suggestions other than the clipboard.

tibbi commented 1 year ago

lets center everything horizontally, even clipboard is moved at the side now

Should it look like before when there are no suggestions, and move it to the side like it is now only when we add autofill suggestions? Because I guess we would need to have some kind of an indication to the users that they have other suggestions other than the clipboard.

oh, didnt know both can be shown at once too. Anyway, ye, lets definitely center the clipboard field, if autofill is empty. Once there is some autofilling, it can be shown as it is now. But autofill is a really rare thing, we shouldnt change the default behaviour because of it.

esensar commented 1 year ago

lets center everything horizontally, even clipboard is moved at the side now

Should it look like before when there are no suggestions, and move it to the side like it is now only when we add autofill suggestions? Because I guess we would need to have some kind of an indication to the users that they have other suggestions other than the clipboard.

oh, didnt know both can be shown at once too. Anyway, ye, lets definitely center the clipboard field, if autofill is empty. Once there is some autofilling, it can be shown as it is now. But autofill is a really rare thing, we shouldnt change the default behaviour because of it.

Yeah, that is what I did in latest updates, It looks like before until autofill suggestions come up. At that point, I shrink it a bit to let users see the suggestions too.

tibbi commented 1 year ago

the clips background shouldnt be that wide though, just wrap its content and be centered as a whole

clipboard

esensar commented 1 year ago

the clips background shouldnt be that wide though, just wrap its content and be centered as a whole

clipboard

My bad, for some reason I thought that was the previous behavior, but looks like I always had long strings in clipboard :smile:

tibbi commented 1 year ago

theres still too much padding on sides, use whatever values are on main branch

esensar commented 1 year ago

theres still too much padding on sides, use whatever values are on main branch

Right, I forgot I added a minimum width. It should be the same as main branch now.

tibbi commented 1 year ago

is that autofill loaded somehow asynchronously? If I click on some edittext, the clipboard snippet blinks a bit in the middle, then it moves to the left, with bitwarden on its right

esensar commented 1 year ago

Yeah, it is actually created by a different process. We only get access to already created views once it is done and add it to the container. It is pretty quick, but still enough to see that blinking.

tibbi commented 1 year ago

okay thanks, its not that big deal, will see what feedback we get

tibbi commented 1 year ago

actually, lets check it with light theme. While the clipboard item is styled well, the autofill one is still dark

tibbi commented 1 year ago

@esensar just pinging you to recheck light theme