Closed esensar closed 1 year ago
I have recorded a simple demonstration of the implementation.
There are some things that I haven't implemented, since I am not sure what UX we are aiming for exactly:
how to reproduce this? What should I do to see the autofill values?
They should appear automatically for the last 2 lines in that included sample screen, but before that you need to have an autofill service configured in your system settings. In my case it is Bitwarden
application, but there should be the default Google
service I think. If you have it set up, something should pop up.
It is also possible that you have no values that can be autofilled. You can then manually add some value in your autofill service to test with this. With Google
it is done through Passwords & Accounts
in system settings. From there it is possible to add a new password and select this application for it.
lets center everything horizontally, even clipboard is moved at the side now
lets center everything horizontally, even clipboard is moved at the side now
Should it look like before when there are no suggestions, and move it to the side like it is now only when we add autofill suggestions? Because I guess we would need to have some kind of an indication to the users that they have other suggestions other than the clipboard.
lets center everything horizontally, even clipboard is moved at the side now
Should it look like before when there are no suggestions, and move it to the side like it is now only when we add autofill suggestions? Because I guess we would need to have some kind of an indication to the users that they have other suggestions other than the clipboard.
oh, didnt know both can be shown at once too. Anyway, ye, lets definitely center the clipboard field, if autofill is empty. Once there is some autofilling, it can be shown as it is now. But autofill is a really rare thing, we shouldnt change the default behaviour because of it.
lets center everything horizontally, even clipboard is moved at the side now
Should it look like before when there are no suggestions, and move it to the side like it is now only when we add autofill suggestions? Because I guess we would need to have some kind of an indication to the users that they have other suggestions other than the clipboard.
oh, didnt know both can be shown at once too. Anyway, ye, lets definitely center the clipboard field, if autofill is empty. Once there is some autofilling, it can be shown as it is now. But autofill is a really rare thing, we shouldnt change the default behaviour because of it.
Yeah, that is what I did in latest updates, It looks like before until autofill suggestions come up. At that point, I shrink it a bit to let users see the suggestions too.
the clips background shouldnt be that wide though, just wrap its content and be centered as a whole
the clips background shouldnt be that wide though, just wrap its content and be centered as a whole
My bad, for some reason I thought that was the previous behavior, but looks like I always had long strings in clipboard :smile:
theres still too much padding on sides, use whatever values are on main branch
theres still too much padding on sides, use whatever values are on main branch
Right, I forgot I added a minimum width. It should be the same as main branch now.
is that autofill loaded somehow asynchronously? If I click on some edittext, the clipboard snippet blinks a bit in the middle, then it moves to the left, with bitwarden on its right
Yeah, it is actually created by a different process. We only get access to already created views once it is done and add it to the container. It is pretty quick, but still enough to see that blinking.
okay thanks, its not that big deal, will see what feedback we get
actually, lets check it with light theme. While the clipboard item is styled well, the autofill one is still dark
@esensar just pinging you to recheck light theme
This closes #199