search

SimpleMobileTools / Simple-Music-Player

A clean music player with a customizable widget, stylish interface and no ads.
https://www.simplemobiletools.com
GNU General Public License v3.0
1.27k stars 412 forks source link

[fr] add a "X" button to the notification #470

Closed throwaway26425 closed 1 year ago

throwaway26425 commented 1 year ago

in NewPipe, when you expand the player notification, a new button shows up to close the notification.

here's a comparison, with both collapsed and expanded notifications:

Simple Music Player NewPipe
screenshot_20221110-145631 screenshot_20221110-145916
screenshot_20221110-145638 screenshot_20221110-145923

I think it would be great to have something similar in your player.

you would see it only if you expand the notification, though.

btw... I don't know if you want me to create a new issue for this, but there should be a setting to disable the preview of the album -and its colors- on the notification. (and just have it in plan gray/dark like in NewPipe)

tibbi commented 1 year ago

what OS version are you using? Those notifications changed quite a bit on Android 13 and so I dont want to mess with the previous versions. Forcing colorless notifications isnt really on the roadmap now.

throwaway26425 commented 1 year ago

I'm using Android 9.

swiping to the left/right to close the notification is really buggy and never really works... that's why I suggested a simple "X" button instead.

throwaway26425 commented 1 year ago

can you please reconsider it?

tibbi commented 1 year ago

we are rechecking some notification and playback related things, it is really messed up at system level

throwaway26425 commented 1 year ago

the "X" button is actually the only method to close the NewPipe's player notification.

https://user-images.githubusercontent.com/85243826/201493841-c53b52b6-eb8c-4c96-89c4-cd06f835eb46.mp4

it's not designed to be closed with the swipe gesture.

tibbi commented 1 year ago

has been added already