SimpleMobileTools / Simple-Music-Player

A clean music player with a customizable widget, stylish interface and no ads.
https://www.simplemobiletools.com
GNU General Public License v3.0
1.28k stars 406 forks source link

App crash on start #566

Closed CodeCubeNeo closed 1 year ago

CodeCubeNeo commented 1 year ago

Error message is something java.NullPointerException: Album shouldnt be null (See screenshot) Screenshot_20230723_100832

tibbi commented 1 year ago

what app version are you using?

CodeCubeNeo commented 1 year ago

Guess. Well if I make such an issue, you can assume I am using the latest. Meaning 5.17.0. Android 9

naveensingh commented 1 year ago

Hey! Are you seeing this toast at every start? If I send an APK, will you be able to check if it fixes your issue? If not, can you provide any info regarding the kind of audio files you have (e.g. source of file)?

Also, are you running some custom ROM or stock Android?

(I'm asking this because I tested audio files without album metadata on Android 9 and no error toasts were shown, they are properly displayed as unknown albums).

CodeCubeNeo commented 1 year ago

Yes. It flashes at every start, then crashes a second later. Stock Android 9 pn Huawei Mate 9. Also yes, you can send me an apk to try. The previous version 5.16.6 works fine (no toast, no crashing.

naveensingh commented 1 year ago

Okay, there were some new changes in 5.17.0 to improve file scanning but it looks like that has led to some device-specific crashes. Here are two test APKs: Version 1: https://github.com/naveensingh/Simple-Music-Player/releases/download/avoid_null_albums/music-player-debug_v1.apk Version 2: https://github.com/naveensingh/Simple-Music-Player/releases/download/avoid_null_albums/music-player-debug_v2.apk

(Both APKs were compiled from https://github.com/SimpleMobileTools/Simple-Music-Player/pull/569)

Please test version 1 and if it doesn't fix your issue, try version 2.

CodeCubeNeo commented 1 year ago

Version 1 works fine.

CodeCubeNeo commented 1 year ago

Version 2 also works.

naveensingh commented 1 year ago

okay, thanks, it'll be released soon.

tibbi commented 1 year ago

going to update the app, thanks for the feedback