Closed naveensingh closed 11 months ago
Tested on a couple of emulators and physical devices, and no issues were found. There is some boilerplate code due to album, artist, and genre fragments having the same layout, I'll remedy that in another PR soon.
@naveensingh Is it acceptable to have six items on the bottom navigation bar?
In this case, we'll let the user decide. IIRC using more than 5 tabs is not recommended, as the text size could vary in different languages leading to a congested appearance but since this feature is optional, we don't need to enforce a limit of 5 tabs. We also allow using two tabs and that's not recommended either.
Alright.
looking good, thanks
Oh how I am looking forward to getting this released. This is the missing piece for me
Closes #372
Screenshots:
Notes:
Audio.Media.GENRE
andAudio.Media.GENRE_ID
are available only on API level 30+ devices. To work around this, we are queryingcontent://media/external/audio/genres/all/members
directly to fetch genre information for each track on lower Android versions. We do not useAudio.Genres.Members.getContentUri("external", genreId)
because fetching track info per genre can be slow when the device has many tracks/genres.