Crash fixes and improvements

[naveensingh]

Changes:

• Avoid NullPointerException in MusicService.updateUI()
  • Fix Glide crashes like Exception java.lang.IllegalArgumentException: cannot start a load for a destroyed activity
  • Removed some useless checks in comparators.
  • Remove the static sorting variable in data classes because the value can be modified while a sort is in progress leading to Exception java.lang.IllegalArgumentException: Comparison method violates its general contract!. Hence, Artist, Album, Track, Folder, Playlist, and Genre classes no longer implement the Comparable interface, and the comparator logic was moved to static getComparator(sorting) methods. As explained here, this error is thrown because the comparator is not transitive but in our case, that only happens because the sorting variable was modified concurrently.

[tibbi]

cannot compile, tracksadapter 282 is missing sorting parameter

[naveensingh]

I see, my bad. My IDE is probably malfunctioning, it compiled successfully and I didn't even get any crashes. I'm checking it now

[naveensingh]

Check it now, please. You can reproduce the crash on 5.17.1 using this:

private fun testSorting() {
    val sortMethods = listOf(PLAYER_SORT_BY_DATE_ADDED, PLAYER_SORT_BY_TRACK_ID, PLAYER_SORT_BY_ARTIST_TITLE, PLAYER_SORT_BY_TITLE, PLAYER_SORT_BY_DURATION)
    ensureBackgroundThread {
        repeat(25) {
            sortMethods.shuffled().forEach { sorting ->
                ensureBackgroundThread {
                    config.trackSorting = sorting
                    Thread.sleep((0L..2L).random())
                    try {
                        applicationContext.audioHelper.getAllTracks()
                    } catch (e: Exception) {
                        throw Exception("failed to sort by ${sorting}, error: ${e.message}")
                    }
                }
            }
        }
    }
}

[tibbi]

ok thanks, Ill trust you on this one :)