Migrate to View binding, SDK 34 and Version catalogs

[naveensingh]

Major changes:

• Migrate build scripts from Groovy to Kotlin DSL
  • Migrate to Gradle version catalogs
• Migrate from Kotlin Kapt to KSP (Kotlin symbol processing) as Kapt is now in maintenance mode.
• Migrate from Kotlin synthetics to View binding
• Target SDK 34:
  • Add FOREGROUND_SERVICE_MEDIA_PLAYBACK permission
  • No other changes are required. I tested using an Android 14 emulator.

Minor changes:

• Close track activity if the track is not found on third-party intents. Related issue: The commons function getRealPathFromUri used at third-party intents isn't working for files with download documents uri, I'll check it soon.
• Fixed some minor adapter-related issues.
• Add proguard rules for Gson to avoid Fatal Exception: java.lang.IllegalStateException: TypeToken must be created with a type argument. See https://r8.googlesource.com/r8/+/refs/heads/main/compatibility-faq.md#troubleshooting-gson-gson. Why do we need Gson here anyway? We can just do Intent.putParcelable(), once I implemented an app using intent parcelables and it worked pretty well.
• Remove Picasso proguard rules.
• Fixed a repeat mode glitch caused by last-minute changes in the media3 PR.

Notes:

• Since we need access to the currently initialized fragments in the main activity, I simply used the PagerAdapter API to store initialized fragments in a list. I didn't look for a novel solution since all this will be rewritten but let me know if I should.

[tibbi]

have you also tested upgrading from master branch in release mode?

[tibbi]

selecting items like folders by long press and drag doesnt work, only works at main tracks fragment

[naveensingh]

have you also tested upgrading from master branch in release mode?

No, I did some tests in release mode but not the migration one. Only tested the upgrade with debug builds, will check it now. I'd tested migration in release mode at the time of media3 changes though

[naveensingh]

selecting items like folders by long press and drag doesnt work, only works at main tracks fragment

I'm on it...

[naveensingh]

selecting items like folders by long press and drag doesnt work, only works at main tracks fragment

I broke it :)

[naveensingh]

have you also tested upgrading from master branch in release mode?

did some basic testing, and nothing looks broken when upgrading from the last release in release mode (on android 14 too)

[naveensingh]

Fixed everything, check now, please.

[tibbi]

if I have 1 playlist only and I long press it, it doesnt have the selected background. Albums opened from Artists tab dont have selected backgrounds either.

[naveensingh]

I have 1 playlist only and I long press it, it doesnt have the selected background

have you pulled the latest changes? I broke it during media3 changes and fixed it above https://github.com/SimpleMobileTools/Simple-Music-Player/pull/592/commits/bebd99bf5ff53a77ae0789e746e13fd10a92cf52

Albums opened from Artists tab dont have selected backgrounds either

I remember that one never really worked and I kept ignoring it, I'm going to fix it now. EDIT: Fixed it.

[tibbi]

right, it works well now, but colors arent properly updated in onResume. The placeholder icon and selectiong texts either.

[naveensingh]

Not sure what I need to do reproduce this. I select some items => go to home screen => reopen the app => everything is just as before

[tibbi]

no need to select anything, just open the app settings, change colors and go back at the main screen, you will see placeholder not being changed. Then you can also long press items.

[naveensingh]

Fixed the color issues and resolved some conflicts. I think the colors were not updated in some other apps with lists, will have to check.

[tibbi]

the placeholder icon at tracks that have no image still doesnt toggle between light/dark properly

[naveensingh]

I didn't have any tracks without thumbnails so didn't notice it, added now.

[tibbi]

yeah looks good now, lets see how will it go ;) Thanks