Playback performance improvements - Githubissues

SimpleMobileTools / Simple-Music-Player

A clean music player with a customizable widget, stylish interface and no ads.

https://www.simplemobiletools.com

GNU General Public License v3.0

1.29k stars 408 forks source link

Playback performance improvements #615

Closed naveensingh closed 1 year ago

naveensingh commented 1 year ago

This PR resolves some of the problems mentioned in https://github.com/SimpleMobileTools/Simple-Music-Player/issues/604

Major changes:

Only set mediaId on media items on the controller side and inflate as needed in the service
Update media3 to 1.2.0-alpha02 (includes some fixes)
Ensure we are loading media in a separate background thread instead of on the player thread.
Implement lazy seek to next/previous media item behavior to avoid doing too much work on large playlists.
Improve tracks recycler view when there are large items in the list

Related issues:

https://github.com/androidx/media/issues/81 (once resolved, this should solve most performance-related issues)
https://github.com/androidx/media/issues/592
https://github.com/androidx/media/issues/592

Tested playing ~4-5k items on a queue on a device with average specs and it worked pretty well. Large playlists kept getting slower and slower, 10k items are still not usable on below-average devices.

tibbi commented 1 year ago

should be good, will do more testing in the real app. Thanks