SimpleMobileTools / Simple-Notes

A simple textfield for adding quick notes without ads.
https://www.simplemobiletools.com
GNU General Public License v3.0
825 stars 271 forks source link

Themes other than Black & White should have access to Accent color #681

Closed SkyDontFall closed 12 months ago

SkyDontFall commented 12 months ago

I noticed that the black and white theme has an extra section called "Accent color of Black & White theme". (Check Image: https://cdn.discordapp.com/attachments/728207504881745983/1146600795589058570/Screenshot_2023-08-31-05-47-46-967_com.simplemobiletools.notes.pro.jpg)

This option should be available for any theme and shouldn't be restricted to the black and white theme. Because if I change even one of these variables: Text color, Background color or Primary color; the option disappears.

Here I changed the text colour to be a little darker: Text Colour Changed Here I changed the primary colour to a dark grey: Primary Colour Changed

In both situations the "Accent color of Black & White theme" option disappears. Slightly darker Text Colour: Darker Text Colour

Slight lighter Primary Colour: Slight lighter Primary Colour

Both make the text of titles unreadable and the checkmarks disappear if I only modify the text colour. Black & White Theme: B&W

Slightly darker Text Colour: Slightly darker Text Colour

Slight lighter Primary Colour: Slight lighter Primary Colour

SkyDontFall commented 12 months ago

I just realized that the accent colour just overwrites the Primary colour. Then what's the point of having this option? Why not just call it a Black (OLED) theme and have the primary colour set to Orange.

Or have the primary colour dictate the colour of the top bar and the accent colour dictate everything else.

Like this: Colours

Colours 2

SkyDontFall commented 12 months ago

Didn't mean to close it. Sorry

tibbi commented 12 months ago

other themes use the primary color instead of accent