Reply from notification broken

[biopsin]

version to 5.16.4 Replying from notification does crazy stuff in this version, please revert changes. I will upload images later as its impossible to describe what is happening.

Edit: se next comment

[tibbi]

well, some description would definitely be needed...

[biopsin]

Reply from notification in version 5.16.3 works fine

Messanger v5.16.4 - lineageos-18.1

M5.16.4_cat.log

// I have replied to sender but reply is no where to find here.. //

// List fills up with digits, with my reply in them //

// Fail from service provider //

[biopsin]

I can confirm each digit thread is a digit from/to reciever phonenumber, but as you can see its broken up and random.. :shrug Might relates to last PR: #497

Also there is no issue replying inside actual thread only quickreply from notification

[yparitcher]

reproduced after update to 5.16.4 same symtoms Please let me know if/how i can test or fix this, Thanks

[yparitcher]

Also, when clicking "mark as read" from a notification, the notification is not dismissed until the notification shade is released.

[tibbi]

can you reproduce it reliably?

[yparitcher]

Yes, Every time i reply from a notification it gets messed up.

The notification not being dismissed when tapping "mark as read" on happens if i have replied in that notification

can you reproduce it reliably?

[tibbi]

@Naveen3Singh check it please

[naveensingh]

Also, when clicking "mark as read" from a notification, the notification is not dismissed until the notification shade is released.

for me this happens on 5.16.1 too.

I'm on it :+1:

[naveensingh]

@yparitcher what app and OS version are you using?

[yparitcher]

@yparitcher what app and OS version are you using?

app 5.16.4 Graphene OS (Android 13)

[bartlibert]

I can confirm this on 5.16.4, installed via F-Droid. OS is Samsung One UI 4.1, based on Android 12.

[Kostas-F]

Version 5.16.4 on Android 7. After replying from the notification area I get an SMS messenger has stopped working error and the message is not sent.No digit thread here. Mark as read works fine for me though (marks as read and dismisses).

[naveensingh]

Hi! For anyone who's willing to test, I have uploaded a test APK here: https://github.com/Naveen3Singh/Simple-SMS-Messenger/releases/download/notification_fixes/sms-messenger-prepaid-debug.apk

this fixes the broken reply but may or may not fix that "mark as read" issue.

@yparitcher if you are willing, pls see if "Mark as read" works with this apk.

thanks

[Kostas-F]

Replies work for me in the test apk. Mark as read also continues to function fine.

The only thing I would add is that, after replying (through the notification), my notification sound plays again. I'm not sure if it used to be this way or if it is intended to but I thought I'd mention it since I would not necessarily expect this behaviour.

Thanks for your work on this.

[biopsin]

@Naveen3Singh testing reply from notification is fixed for me. @Kostas-F I dont experience any second notify sound.

Anyways thank you for taking the time to work on this.

[Kostas-F]

@biopsin Could have to do with my extremely outdated Android 7.

[naveensingh]

my notification sound plays again

@Kostas-F nothing wrong with your android version. It's a bug and it'll be fixed :)

thank you all for the response.

[naveensingh]

@yparitcher

Also, when clicking "mark as read" from a notification, the notification is not dismissed until the notification shade is released.

this seems like a platform glitch on Android 13 devices, I can reproduce this issue with google messages too. Just reply to a message and hit the "Mark as read" button within one or two seconds of replying.

Google messages

https://user-images.githubusercontent.com/36371707/206210789-344dca4a-2476-4253-be1b-cd73ce47623e.mp4

As a workaround, always wait for two seconds or more before hitting the "Mark as read" button and it won't cause ghost notifications anymore. Still reasoning whether we should force this delay programmatically