search

SimpleMobileTools / Simple-SMS-Messenger

An easy and quick way of managing SMS and MMS messages without ads.
https://www.simplemobiletools.com
GNU General Public License v3.0
600 stars 218 forks source link

Block messages from non phone number address when block hidden is enabled #677

Closed esensar closed 1 year ago

esensar commented 1 year ago

This closes #307

esensar commented 1 year ago

Should we add a warning to the users that this setting will also block any one time passwords that would be sent via SMS? I am not sure if it is completely clear from the setting label.

tibbi commented 1 year ago

not sure what you mean. Hidden numbers arent related to one time passwords, it is about the CLIR service, when the senders phone number is not shown. It is usually shown as Private or so.

esensar commented 1 year ago

not sure what you mean. Hidden numbers arent related to one time passwords, it is about the CLIR service, when the senders phone number is not shown. It is usually shown as Private or so.

I have not found a way to send an SMS like that. I can do that when it comes to calls, but when it comes to SMS I haven't found an option to make the number private, it seems to always display it to receivers.

In this PR I just did what was requested in the issue (https://github.com/SimpleMobileTools/Simple-SMS-Messenger/issues/307), by blocking SMS from senders that don't have phone number, but only name.

tibbi commented 1 year ago

so you have the CLIR function but it doesnt work on messages? Or how have you reproduced it?

esensar commented 1 year ago

Yes Just to make sure I am not getting something wrong and that we are talking about the same thing, I have enabled it by setting the Caller ID to Hide number on my SIM. I confirmed that it works correctly by making a call to another device and it was displayed as Private number. When I sent an SMS after that, it displayed my number. I am not aware of CLIR existing for SMS, or I have at least not been able to find that setting.

tibbi commented 1 year ago

right, that is the behaviour we want. Lets disable this setting then. It was ment to be used with the private numbers, not bank codes. Thanks though