SimpleMobileTools / Simple-SMS-Messenger

An easy and quick way of managing SMS and MMS messages without ads.
https://www.simplemobiletools.com
GNU General Public License v3.0
600 stars 218 forks source link

Add message details menu button #682

Closed esensar closed 1 year ago

esensar commented 1 year ago

Adds a "Properties" menu button in conversation, when one message is selected, which displays details about the message:

This closes #19

TODO

esensar commented 1 year ago

I am not sure if we need to keep track of date_sent everywhere, since for now I have decided to keep it the same as date in case of sent messages and only update it in case of incoming messages. I have noticed that Google's Messages application has the same behavior (only displaying received time if it is an incoming message).

When it comes to sender/receiver phone number, I only display the number of the other participant, since getting the phone number of used SIM does not seem to have a reliable solution (even Google's Messages requires user to enter their phone number to display it in details).

tibbi commented 1 year ago

Sent at doesnt seem to work, it always shows 1.1.1970 to me. By showing sent/received I meant always showing 1 only. At messages that we sent, we show "Sent at", at messages that we received we show "Received at". Never both. Remove the message type, doesnt make sense showing SMS/MMS there. Also redesign the dialog, make it look like file properties with a label and value. And at Sender lets show the contacts name (if we have it) with the number after it in brackets.

tibbi commented 1 year ago

as Sent at doesnt work, guess we can use the received value or whatever other date we have at the messages we sent too, to show a reasonable date when we sent the message.

esensar commented 1 year ago

as Sent at doesnt work, guess we can use the received value or whatever other date we have at the messages we sent too, to show a reasonable date when we sent the message.

I think what we have currently should work fine, I think I broke it in attempt to enable showing both "Sent at" and "Received at", since I thought that was the goal (I noticed some other apps supported that).

I will remove that and it should make everything much more simple.

tibbi commented 1 year ago

alright thanks, seems to work well to me