SimpleMobileTools / Simple-SMS-Messenger

An easy and quick way of managing SMS and MMS messages without ads.
https://www.simplemobiletools.com
GNU General Public License v3.0
600 stars 218 forks source link

Ensure that MMS reception ACK is sent to prevent duplicate MMS #687

Closed esensar closed 1 year ago

esensar commented 1 year ago

This implements the getMmscInfoForReceptionAck method in MmsReceiver which is according to android-smsmms library required for some carriers, since otherwise MMS would be duplicated. Unfortunately, accessing MMSC information is more restricted with each version of Android and this implementation relies on system database on older versions and uses APN database included with android-smsmms for newer versions, which will work only on the default SIM card.

TODO

esensar commented 1 year ago

I have confirmed that receiving MMS still works with both of these fixes, but since I haven't been able to reproduce the original issue, I can't confirm if this fixes is. This current draft only uses the first fix (https://github.com/tibbi/android-smsmms/pull/13). I can update this PR to also include second fix after first one is merged and if everything is fine, we could merge all of it.

tibbi commented 1 year ago

tested this PR itself as it is now, it didnt help. Accepted https://github.com/tibbi/android-smsmms/pull/13 , you will update this PR?

esensar commented 1 year ago

Alright, will update. I will now also include changes from https://github.com/tibbi/android-smsmms/pull/14 to see if these will help

tibbi commented 1 year ago

nice thanks, this seems to work just fine to me :) Lets accept it and see what feedback we get.