Closed esensar closed 1 year ago
Basic support for recycle bin for messages is here, but there are some things that I would like to clear up, since I am not really sure how to handle them:
I would also like to reuse some of the stuff that is done in https://github.com/SimpleMobileTools/Simple-SMS-Messenger/pull/698, so it would be good to get that one merged before this. I will still do some work on this one for testing purposes, but I won't be able to finalize it before that one gets merged.
This is now ready for testing and review. There is one thing that I am not sure how to best handle. I don't think it is handled in the gallery either.
Right now, when we disable recycle bin, we just ignore that it exists, but items are still there in the recycle bin. If user re-enables it after a long time, these items will be deleted because enough time has passed. Should we restore all messages when recycle bin is disabled, or is this behavior fine?
that behaviour is fine. Delete stuff after 30 days, do not care about any settings.
lets mention the recycle bin at deleting a message, like in the gallery. Use the move_to_recycle_bin_confirmation
string from commons
conversation snippet below the title in the recycle bin is wrong, it shows the same message snippet as on the main screen, even if the deleted messages have other text
Queries became a bit more complex now for reading conversations, because I had to ensure that both regular and recycle bin threads display correct snippet, since both can be affected depending if latest or some older message was moved to recycle bin.
well, as long as it works, it shouldnt be a big issue :) I dont expect people having millions of messages, so it should be quick too
nice thanks, looks good now
This adds support for moving messages to recycle bin instead of deleting them right away. The feature is not active by default.
This closes #451
TODO
ThreadActivity