SimpleMobileTools / Simple-SMS-Messenger

An easy and quick way of managing SMS and MMS messages without ads.
https://www.simplemobiletools.com
GNU General Public License v3.0
583 stars 214 forks source link

Make "Delete" notification button optional #778

Open pitastrudl opened 9 months ago

pitastrudl commented 9 months ago

Hi, I realize this option was requested multiple times in https://github.com/SimpleMobileTools/Simple-SMS-Messenger/issues/89 and https://github.com/SimpleMobileTools/Simple-SMS-Messenger/pull/668 and I see why people would want it, for me personally it does have some drawbacks. When receiving the SMS, I sometimes instead of clicking on the actual message, I missclick and delete it instead. OTP messages are not important but I do receive bank statements and withdrawal notifications by SMS if that happens which are deemed important.

I would propose this feature would be made optional or made opt-out if people or the maintainers agree.

Spike-from-NH commented 9 months ago

This would be a useful change to the new Recycle Bin option. When deleting a message, do you want to ➊ Delete after confirmation? ➋ Delete without confirmation? ➌ Recycle (without confirmation because you can recover it)?

pitastrudl commented 9 months ago

Currently I enabled recycle bin which was a nice thing to be added.

Replying to @Spike-from-NH,

➊ Delete after confirmation?

This would be a viable solution but since you're doing this action from the notification bar it might be disturbing UX wise to whatever is happening on the screen.

➋ Delete without confirmation?

This is the current state.

➌ Recycle (without confirmation because you can recover it)?

This is like the delete function in Windows, Android stock gallery (Samsung gallery). I would take this as a default behavior when deleting as a user might not be aware it's deleted permanently but would think it's put in a recycle bin.

Regardless of the recycle bin, making the delete option opt-in or having "Reply" or some other feature instead of "Delete" would be one of the ways to go, as most messaging apps do making interaction with the notification bar less "dangerous" as it is.

Spike-from-NH commented 9 months ago

Not disturbing at all, @pitastrudl. ➊ doesn't mean delete after being viewed! I should write: ➊ Delete after asking for confirmation ➋ Delete without asking for confirmation

I don't delete from notification at all, but read the full message, then maybe delete by long-pressing the text and tapping the trash can. ➊➋➌ should only affect what happens next. Whether the notification makes it too easy to delete-before-reading is a separate issue.

acress1 commented 8 months ago

Hi, Sorry to disturb but I don't have anything like that in my notifications, only Reply and Mark as Read, but cannot set up somewhere a Delete option... My app is up to date. Don't understand.

Thanks !

Spike-from-NH commented 8 months ago

I don't have anything like that in my notifications, only Reply and Mark as Read, but cannot set up somewhere a Delete option...

I agree, @acress1; that is how it works now. We are discussing a proposal. I should not have said, "I don't delete from notification at all"—as though this were an option; it is not (yet)!

acress1 commented 8 months ago

Ok, thanks !

pitastrudl commented 8 months ago

Hi, Sorry to disturb but I don't have anything like that in my notifications, only Reply and Mark as Read, but cannot set up somewhere a Delete option... My app is up to date. Don't understand.

Thanks !

This option only shows for messages that come from numbers that don't support replies or cannot receive them, so usually it's TOTP/2FA message services.

pitastrudl commented 8 months ago

Not disturbing at all, @pitastrudl. ➊ doesn't mean delete after being viewed! I should write: ➊ Delete after asking for confirmation ➋ Delete without asking for confirmation

I don't delete from notification at all, but read the full message, then maybe delete by long-pressing the text and tapping the trash can. ➊➋➌ should only affect what happens next. Whether the notification makes it too easy to delete-before-reading is a separate issue.

Gotcha.

Platway commented 5 months ago

This would be a great feature. This only thing that is missing in my point of view. Thanks for the great work!

inson1 commented 5 months ago

@Platway SMT apps were sold to ad company. There is already fork https://github.com/FossifyOrg.