Google Fonts

[dovy]

I have a fully function Google fonts option. My question pertains to the key.

I can easily cache the possible fonts. We could also do one or multiple of the following:

• Have an option for a api key for users to fill out.
• Have a variable to set in the PHP for devs.
• Create a time before the next query.

I'm prone to do all three. It wouldn't take much. I already have the proper parsing code.

Thoughts?

[dovy]

@teamcrisis Feel free to chime in.

[teamcrisis]

I don't see the api key method being used much - at least not by commercial themes. I don't think it's practical.

I like idea 2 & 3 though...

[dovy]

@teamcrisis Why isn't it practical? An API key a developer embeds, the user never sees, and is only used maybe once every 2 weeks per theme? Seems pretty practical to me. Just my 2c. ;)

[teamcrisis]

I'm not sure many devs would want to use their keys in a commercial theme. I thought there was some limit set by Google per key (I could be wrong). If you have a very successful theme or use the same key throughout all your commercial themes, the limit may be problematic.

Maybe I'm just being paranoid. In any case, if you already have a working prototype or are setup for all three methods, no reason to really exclude it.

[dovy]

@teamcrisis The limit is like 20k. Heh. But either way, we'll build for all. ;)

[teamcrisis]

Yeah, just looked it up. It's 10k requests/day with 10 requests per second. Seems reasonable.

[dovy]

;)

Unless you're Avada (ThemeFusion) and made a mistake by setting the refresh to hourly, hah.

[teamcrisis]

I think a weekly refresh is reasonable given a 10K/day limit, but bi-weekly is fine too.

[teamcrisis]

The only issue I see with the key idea is what prevents someone from using your key maliciously?

[dovy]

@teamcrisis You can make multiple keys. We'll make it fail gracefully too.

[dovy]

Resolved. See release 0.1.2 https://github.com/SimpleRain/SimpleOptions/releases/tag/0.1.2