search

Simplero / Roadmap

Roadmap for Simplero
https://simplero.com
13 stars 5 forks source link

Support for fontawsome needed #461

Closed casvos closed 5 years ago

casvos commented 5 years ago

I use special icons in my present website and would like to use it in Simplero as well, both in text and Buttons etc.

Any thought about making this happen in the near future?

https://fontawesome.com

calvincorreli commented 5 years ago

I believe you should be able to add this by editing your site theme's code. Just add the LINK tag to your layout/theme.liquid file.

https://fontawesome.com/start

I don't think it's something we want to add to all sites by default.

casvos commented 5 years ago

Hi,

I followed your instructions and checked those on fontawesome’s website as well, and put the correct link tag in layout/theme.liquid.

Unfortunately, this doesn’t work.

When inserting icons, e.g. , in the html of a Simplero page or anywhere in Simplero, it gets deleted.

//Carl

5 feb. 2019 kl. 16:01 skrev Calvin Correli notifications@github.com:

I believe you should be able to add this by editing your site theme's code. Just add the LINK tag to your layout/theme.liquid file.

https://fontawesome.com/start https://fontawesome.com/start I don't think it's something we want to add to all sites by default.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Simplero/Roadmap/issues/461#issuecomment-460669331, or mute the thread https://github.com/notifications/unsubscribe-auth/Ar6iLGKAOfhPxNrAaz8Rwb08oCG48_efks5vKZyygaJpZM4ai586.

calvincorreli commented 5 years ago

It looks like you're closing the <i> tag with something other than </i>.

Is it a lowercase "L"? It needs to be the same thing.

casvos commented 5 years ago

Sorry, it’s just a typo. The closing is an lowercase i

6 feb. 2019 kl. 15:53 skrev Calvin Correli notifications@github.com:

It looks like you're closing the tag with something other than .

Is it a lowercase "L"? It needs to be the same thing.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Simplero/Roadmap/issues/461#issuecomment-461051503, or mute the thread https://github.com/notifications/unsubscribe-auth/Ar6iLHHlIQUmPI5kRYDpmSH9M4RxcH9lks5vKux-gaJpZM4ai586.

calvincorreli commented 5 years ago

Send me a link to the page, please.

casvos commented 5 years ago

https://new.humanawareness.se/test-page

I’ve tried to insert different Fontawsome icons on this page in the html code of the text section, but the code just disappears.

6 feb. 2019 kl. 23:08 skrev Calvin Correli notifications@github.com:

Send me a link to the page, please.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Simplero/Roadmap/issues/461#issuecomment-461207516, or mute the thread https://github.com/notifications/unsubscribe-auth/Ar6iLCcHSlhw2HFcSga0KYQNsl1ZK6MXks5vK1JegaJpZM4ai586.

calvincorreli commented 5 years ago

I see. The TinyMCE editor is a little aggressive in replacing i tags with em tags, and then removing empty em tags.

This is a work-around that gets the job done:

<span class="fas fa-igloo">​&#8203;</span>

It uses the span tag option, and then includes a "zero-width space" so that TinyMCE won't remove it.

casvos commented 5 years ago

Thank you sooo much for your help!

I wish you a great day!

7 feb. 2019 kl. 15:14 skrev Calvin Correli notifications@github.com:

I see. The TinyMCE editor is a little aggressive in replacing i tags with em tags, and then removing empty em tags.

This is a work-around that gets the job done:

​​ It uses the span tag option, and then includes a "zero-width space" so that TinyMCE won't remove it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Simplero/Roadmap/issues/461#issuecomment-461435321, or mute the thread https://github.com/notifications/unsubscribe-auth/Ar6iLN8yxPeDL33asQ4mkMYARXhkwhIHks5vLDS_gaJpZM4ai586.