search

SimplicityApks / ReminderDatePicker

A Google Keep-like Date and Time Picker for reminders
Apache License 2.0
74 stars 26 forks source link

Adding some methods #27

Closed chrisonline closed 9 years ago

chrisonline commented 9 years ago

Can you please add some methods?

I miss "setFirstDayOfweek" and "setCloseOnSingleTapDay"!

SimplicityApks commented 9 years ago

Mmhh wouldn't it be easier if we just had a getter for the DatePickerDialog? That way we don't have to keep syncing with those methods as new ones are added upstream and can also easier replace the built-in DateTimePicker library

chrisonline commented 9 years ago

Yeah a way better. Good idea, can you add this?

SimplicityApks commented 9 years ago

There you go, I made it so that it returns null if a custom picker is set (so that you don't get an object that is never used and then wonder why your changes aren't visible).

chrisonline commented 9 years ago

Great thanks! I now use the Gradle compile option, so is there a way I can simple test this? Or do I need to download the whole project and add it with "compile project"?

SimplicityApks commented 9 years ago

Good question, but I think there is no other way than cloning the repo and manually adding it to your build.gradle with the compile project option. That is why maven is so nice ;)

chrisonline commented 9 years ago

Tried it and it works, thanks! When do you plan to make a new release?

SimplicityApks commented 9 years ago

Closed with 1.2.1 release