search

Simplix-Softworks / SimplixStorage

Library to store data in a better way
Apache License 2.0
138 stars 25 forks source link

Improvements #43

Closed ProfliX closed 3 years ago

ProfliX commented 3 years ago

Removed redundant call toString() Optimized imports Rearanged/refactored code (for better readability) Val(same as var but with final) and var (lombok) usement for whole project (where is actually needed). Unused code suppressed Removed Map,Collection,List raw types (Transformed them to valid ones) FileUtils > extractResource() > Asserted not null inputStream DataStorage > getEnum > assertet object instanceof String; Added JavaDocs to ConfigSettings and ReloadSettings LightningSerializer > deserialize improvement LightningException > Removed NotNull annotation from primitive type members. Bumped new version > 3.2.4

KotlinFactory commented 3 years ago

Thank you so much for your dedication and work. I think its great that you want to improve SimplixStorage. Please split your PR into smaller pieces (One for each point (Like remove redundant toString() call)) and we can approve them.

Regards, Leonhard