search

Simplix-Softworks / SimplixStorage

Library to store data in a better way
Apache License 2.0
138 stars 25 forks source link

Rethrow exceptions #79

Open ChimpGamer opened 1 year ago

ChimpGamer commented 1 year ago

Is your feature request related to a problem? Please describe. At the moment we as users of this api cannot act on exceptions thrown within this api since they are already being caught.

Describe the solution you'd like A clear and concise description of what you want to happen. Rethrow the exception so we as users of the api can handle them they way we want to.

Describe alternatives you've considered We'll a different api but without this issue there is no need to.

Additional context Some examples of internal exception handling within the api https://github.com/Simplix-Softworks/SimplixStorage/blob/master/src/main/java/de/leonhard/storage/internal/FlatFile.java#L126 https://github.com/Simplix-Softworks/SimplixStorage/blob/master/src/main/java/de/leonhard/storage/internal/FlatFile.java#L282 https://github.com/Simplix-Softworks/SimplixStorage/blob/master/src/main/java/de/leonhard/storage/internal/FlatFile.java#L298

KotlinFactory commented 1 year ago

Hi thats a very valid critique. Can you create a PR to change this?