Simply-Love / Simply-Love-SM5

a StepMania 5 theme for the post-ITG community
Other
190 stars 144 forks source link

Switching from Waterfall 0.6.2 to Simply Love breaks everything #258

Open Hay1tsme opened 3 years ago

Hay1tsme commented 3 years ago

I just built the stepmania-5_1-new branch, and the skin gives many of lua errors. The start button isn't there so it is quite literally unplayable. Examples below: StepMania-release-symbols_Bl8RdVPMvJ StepMania-release-symbols_Ef9VhgLcXp

natano commented 3 years ago

Hm, I've been playing on 5_1-new for the last two years, so there must be something special going on here.

What platform is this? Is this a normal install or a portable one? Is this a new theme install or did you upgrade from an older version of Simply Love? Can you also provide the log files and the ThemePrefs.ini? That would help a lot!

Hay1tsme commented 3 years ago

Hello! To answer your questions...

After testing on a fresh build on a different PC I believe the issue comes from switching from the ECFA 2021 Theme (a mod of the Waterfall theme I believe) to Simply Love. Switching from the default SM5 Theme to Simply Love results in the following screen. image

As for log files and ThemePrefs.ini, I can't seem to find them, my apologies. I am currently away from the original PC and will look for logs on that install as soon as I get back to it.

Hay1tsme commented 3 years ago

I fixed this issue by adding version = version:gsub("-UNKNOWN","") to SL-SupportHelpers.lua, as it was messing with the system SL uses to determine what version is being used.

Unfortunately, the original issue of the skin completely breaking when switching from the ECFA 2021 to SL still stands.