search

Simply-Love / Simply-Love-SM5

a StepMania 5 theme for the post-ITG community
Other
204 stars 144 forks source link

(GrooveStats integration) leaderboard doesn't show after passing a song on StepMania 5.1.0-b2 #528

Closed Vanishing-Point closed 6 months ago

Vanishing-Point commented 8 months ago

Using GrooveStats Launcher v1.6.0, StepMania v5.1.0-b2 and Simply Love v5.4.0.

In the results screen after passing a ranked song in ITL Online 2024, submitting finishes successfully (can be seen in online leaderboards) and the screen gets darkened. However, the leaderboard window doesn't show up. Furthermore, the submission status incorrectly says "Submitting ...". 2024-03-12_163842

The leaderboard window works as normal when accessed from the song selection wheel screen.

Horsey- commented 8 months ago

Same exact symptoms here

concubidated commented 7 months ago

Was a bug in GSlauncher, need to update

https://github.com/GrooveStats/gslauncher/commit/e2f82cead41216193ab967039301fdcbc6102271

Vanishing-Point commented 6 months ago

Okay, it took me a while but I have tested it out. Indeed, the patch @concubidated linked fixes the issue. 2024-05-13_135920 It still says "Submitting ...", but maybe this has to do with me also modifying the launcher to send scores through BoogieStats, I dunno. Either way, the main issue is fixed.

However, the code fix is not part of the final release of the GrooveStats Launcher (1.6.0), so unfortunately anyone else with this issue has to apply the patch themselves and follow the guide for building the GrooveStats Launcher manually: https://github.com/GrooveStats/gslauncher/blob/main/doc/building.md

But that's okay, since I strongly suspect most of the people participating in GrooveStats-hosted online events have already made the switch to ITGMania, and the rest of us will be forced to do that anyway in the near future. Personally, I only haven't done that yet because I'm too obstinate. And the early decent/way off correction mechanism will be a huge boon for these types of events.

Horsey- commented 6 months ago

Yeah,I also have the visual bug where it’s stuck saying submitted.