search

Simply-Love / Simply-Love-SM5

a StepMania 5 theme for the post-ITG community
Other
200 stars 145 forks source link

ScreenGameplay::TimingWindowScale program error when Judge != 4 #530

Closed LumiStar2000 closed 4 months ago

LumiStar2000 commented 6 months ago

Reproduction steps: on ITGmania 0.8.0 and SL 5.4.0 for ITGmania, select any judgement other than Judge 4 (TimingWindowScale != 1), and attempt to play a song. Error is thrown 100% of the time.

I believe the bug is related to the options display at song start. The song appears to play fine when "Ignore" is selected, and "xx% Judgement Windows" displays on the results screen, all as intended, but the options display just ends with a ",". image image

SugoiFactory commented 6 months ago

The language string is missing for ScreenGameplay, I've made an MR to address this: https://github.com/Simply-Love/Simply-Love-SM5/pull/531