search

Simply-Love / Simply-Love-SM5

a StepMania 5 theme for the post-ITG community
Other
189 stars 143 forks source link

Fix MeasureLines on non-english values #544

Closed snil4 closed 2 months ago

snil4 commented 2 months ago

Seems like SaveSelections doesn't work on Values that are not in english, in those cases it uses a non-existing value instead. I tested it both on english and other languages and I couldn't find an unexpected behavior without SaveSelections.

Before

https://github.com/Simply-Love/Simply-Love-SM5/assets/74380856/4b76d60e-e3a1-4e2c-8a64-111acfaf5aa4

After

https://github.com/Simply-Love/Simply-Love-SM5/assets/74380856/9d720e36-f94a-4556-8ce0-5430de6aeb8b

teejusb commented 2 months ago

This is already fixed via: https://github.com/Simply-Love/Simply-Love-SM5/commit/43ea43fbdb9c858de75cc3ec93d58ac6c70dea99

teejusb commented 2 months ago

Related issue: https://github.com/Simply-Love/Simply-Love-SM5/issues/538