search

Simply-Love / Simply-Love-SM5

a StepMania 5 theme for the post-ITG community
Other
189 stars 143 forks source link

Make MeasureLines work correctly with localized values #554

Closed phantom10111 closed 2 weeks ago

phantom10111 commented 2 weeks ago

Use Values instead of Choices to properly display localized choices in the menu and remove SaveSelection() since the default function does the right thing automatically.

teejusb commented 2 weeks ago

Hmm iiuc this won't work without additional changes because to code to disable measure lines specifically looks for the string "Off" which when localized wouldn't be correct and would result in measure lines always being on.

phantom10111 commented 2 weeks ago

It does work because the default behavior of SaveSelection() is to use Values which contains the non-localized strings. The bug in the original code was caused by using Choices instead which contains the localized strings used for display. I also tested it locally with Polish localization to make sure.

teejusb commented 2 weeks ago

OH I see where I went wrong. Perfect thanks for the fix!