ITGm Crash from GS/SRPG theme detection

[xancara]

crashinfo.txt

This is the crash that occurs. It is easily reproducible and I can provide a video if necessary. I figured this would be best handled here but I will throw it over to ITGmania if it is seen as more of an engine issue rather than needing handled in theme.

To Reproduce:

Setup: Fresh Install during SRPG8 dates -- in Coin Mode on Free Play with Event mode on. Enable GS.

1. Press the start button on title screen
2. As soon as GS check mark appears, hit start to enter game
3. Crash will occur -> Caused by transition to "SRPG8 has started. Would you like to change the theme?"

If you let the SRPG8 Prompt happen and exit it, it does not crash. There is an additional issue after returning from the SRPG8 Prompt as it acts as if it is in Home Coin mode always when returning from that prompt. I can create a separate issue for that if necessary.

[teejusb]

Sounds like a race condition where you're trying to start your set but we're also programmatically trying to transition to the SRPG8 theme screen and the game can't really transition to two screens at once. Can you still reproduce if you change this line:

https://github.com/Simply-Love/Simply-Love-SM5/blob/itgmania-release/BGAnimations/ScreenSystemLayer%20overlay.lua#L354

To:

if last_active_event ~= "SRPG8" and !SCREENMAN:GetTopScreen():IsTransitioning() then

(we probably wanna mode the themeprefs.set to this condition as well, but can do it later)