SimplyPrint / OctoPrint-Creality2xTemperatureReportingFix

Fixes the temperature reporting from the Creality Ender-3 v2 printer
MIT License
27 stars 7 forks source link

[BUG] Plugin fix isn't working with CR6 SE #6

Closed khanh-codes closed 4 years ago

khanh-codes commented 4 years ago

Installed the plugin today to test on my CR6 SE - default firmware (v1.02), but the temperature output did not change.

Things tried:

Let me know if you need any logs

AlbertMN commented 4 years ago

Hi there. GitHub isn't very good at sending me notifications about issues right now... So sorry for the late reply!

Can you please send me both octoprint.log and serial.log? :)

khanh-codes commented 4 years ago

Hey, no worries. I want to make sure something before sending over the logs - Is this fix supposed to change the temperature output under the Terminal tab on Octoprint so that it can get properly filtered? Or is this only for the temperature readings being sent to the Temperature tab on Octoprint?

AlbertMN commented 4 years ago

This plugin "intercepts" the GCODE, checks if it has a case of "double-everything-itis" and returns a parsed (fixed) temperature report to OctoPrint. So the output in the terminal should still be weird AFAIK, but the temperature that shows everywhere on the panel should be fixed. A simple screenshot of your terminal, with a temperature reporting (which is done quite frequently), and we can determine whether this plugin will fix your issues or not.

khanh-codes commented 4 years ago
Screen Shot 2020-09-23 at 12 04 10 PM

Here's a screenshot. This is the terminal output with the plugin installed. I guess what I'm seeing is expected behavior?

AlbertMN commented 4 years ago

Yes :) That's the expected behavior.

khanh-codes commented 4 years ago

Ah, if that's expected then I guess I'll just have to change the filtering regex. Thanks for your insight

AlbertMN commented 4 years ago

This plugin should fix this for you - it should have the regex that fixes this. What seems to be the problem? Do you still not see the temperatures reported properly?

khanh-codes commented 4 years ago

The suppress temperature messages toggle isn't filtering