SimplyPrint / OctoPrint-SimplyPrint

Official SimplyPrint plugin
GNU General Public License v3.0
11 stars 1 forks source link

Crash on start of print via. OctoPrint (most likely) #38

Open AlbertMN opened 1 year ago

AlbertMN commented 1 year ago

SP WS connection was online, but dropped when the user started a print via. OctoPrint. I think this is the important snippet of the linked log;

2022-09-30 21:52:19,024 - tornado.application - ERROR - Exception i
n callback functools.partial(<bound method SimplyPrintWebsocket._on_print_start of <octoprint_simplyprint.websocket.simplyprint.SimplyPrintWebsocket object at 0x7115dc30>>, {'name': 'CE3_3dbenchy (1).gcode', 'path': 'CE3_3dbenchy (1).gcode', 'origin': 'sdcard', 'size': 3241546})
Traceback (most recent call last):
  File "/home/pi/OctoPrint/venv/lib/python3.7/site-packages/tornado/ioloop.py", line 740, in _run_callback
    ret = callback()
  File "/home/pi/OctoPrint/venv/lib/python3.7/site-packages/octoprint_simplyprint/websocket/simplyprint.py", line 872, in _on_print_start
    if self.file_manager.has_analysis(dest, path):
  File "/home/pi/OctoPrint/venv/lib/python3.7/site-packages/octoprint/filemanager/__init__.py", line 914, in has_analysis
    return self._storage(destination).has_analysis(path)
  File "/home/pi/OctoPrint/venv/lib/python3.7/site-packages/octoprint/filemanager/__init__.py", line 1045, in _storage
    raise NoSuchStorage(f"No storage configured for destination {destination}")
octoprint.filemanager.NoSuchStorage: No storage configured for destination sdcard

e3s1-octoprint-4_3kkihy.log Sentry link; https://sentry.io/organizations/simplyprint/issues/3632481739/?project=6611344&query=is%3Aunresolved

jneilliii commented 1 year ago

I think your sentry link isn't correct...

Got an exception while sending event MetadataAnalysisFinished (Payload: {'name': '77.gcode', 'path': 'SimplyPrint/77.gcode', 'origin': 'local', 'result': {'analysisPending': True}}) to <bound method Printer._on_event_MetadataAnalysisFinished of <octoprint.printer.standard.Printer object at 0xb2296e90>>

but a FileNotFoundError for /home/pi/.Printer5/uploads/SimplyPrint/75.gcode in which the paths don't match and the attached log indicates a file named CE3_3dbenchy (1).gcode being printed from SD card causing the error.

Either way, I'm pretty sure I did test printing from OctoPrint while doing the webcam stuff but the issue may be related to printing from SD card. Will need to investigate this one further.

AlbertMN commented 1 year ago

So, apparently this setup is a bit more complex; the user was using both Mainsail and OctoPrint, and this error seemed to occur when starting the print from Mainsail... The SP plugin for Moonraker/Mainsail was not installed, so it's not because of any "double-things".

Is this a common thing to do? I've never heard of running both.

jneilliii commented 1 year ago

I can't think of anyone on OctoPrint discord mention running both on same instance/printer outside of trying the Klipper options out.

jneilliii commented 1 year ago

I think this issue was actually related to printing from SD card, as metadata analysis doesn't exist for that scenario. I've accounted for that with the above commit.