SimplyStaking / panic

PANIC Monitoring and Alerting For Blockchains
Apache License 2.0
81 stars 31 forks source link

UAT Batch Fixes: Group 3 #354

Closed zimaah closed 2 years ago

zimaah commented 2 years ago

User Story

Group 3 includes a set of findings from the UAT.

Description

  1. Channel type filter unnecessarily displayed
  2. Channel without severity
  3. Incomplete e-mail config
  4. Twilio without phone number to call
  5. Tertiary color for Twilio notice
  6. Doubled L for Twilio

Requirements

  1. If the data table is empty, we need to hide the filter
  2. By default, a disclaimer (with color tertiary) will always be displayed underneath the severity checkboxes 2.1 Attention for when the channel type is set to Twilio: here we don't need to display it
  3. All inputs for Email channel are required
  4. We need to make the Twilio without phone number to call required
  5. When the channel is Twilio there is a specific warning being displayed, we need to change its color to tertiary
  6. The channel type name for Twilio is mistyped in the DB. We need to change it from Twillio (double l) to Twilio (single l)

Acceptance criteria

All items must be sorted following the requirements. If something isn't clear, please reach out to the team as soon as possible.