SimplyStaking / panic

PANIC Monitoring and Alerting For Blockchains
Apache License 2.0
82 stars 31 forks source link

Alert Step Re-Design: Implement save button instead of onChange #363

Open itsciccio opened 1 year ago

itsciccio commented 1 year ago

Description

The delay on every update in the alerts page is too quick, causing many API calls.

Update: It has been decided to overhaul this page by implementing a Save button instead of the current onChange logic as it is the most simplistic way forward.

Requirements

- [ ] Extend debounce time to 2seconds. - [ ] Test by altering the configurations and check that the time between API calls is reasonable.

Acceptance criteria

Scenario: I wish to edit an alerts configuration for any sub-chain Given: A valid config either fresh or edited Then: A reasonable time between API calls

Scenario: Updating PANIC Configs Given: Some changes made in the page When: Save button pressed Then: Alert config saved in DB.

itsciccio commented 1 year ago

The component is designed to update a single change at a time, as by extending the debounce will solve the original issue yet cause other issues. This page is to be converted in a way to have a Save button (similar to the sub-chain step). As for the time being, this issue will be skipped as PANIC still functions well without this change, and as a ticket it will require an overhaul for the alert setup page.