Nikhil/add peering alert

[nivasan1]

In this PR

• I defined two new alerts validator_is_peered_with_sentinel and node_is_peered_with_sentinel, these are solvable conditional alerts, raised on the condition that the monitored node is not peered to the sentinel
  • The severity of these alerts are info / warning respectively

    Major Changes

    • Modified the _get_tendermint_rpc_direct_data method to check if a mev-info field of the /status response exists
    • If so, the node is considered to be running mev-tendermint, and the status of the is_peered_with_sentinel field of the response will be acknowledged if the alert is enabled
    • Otherwise, even if the alert is enabled, the alert will be ignored
    • Modified the transformer / alerter for the cosmos node to read the modified meta-data / data fields of the tendermint-rpc response

      Relevant Files

    • alerter/src/data_transformers/node/cosmos.py
    • alerter/src/monitor/node/cosmos.py
    • alerter/src/alerter/alerters/node/cosmos.py

      Testing

    • Modified the relevant unit tests for the cosmos node alerter, monitor and data_transformer
    • Tested with a live node running both mev-tendermint and regular tendermint

[dillu24]

Hey @nivasan1 should we review this? I am asking because you closed it.

[nivasan1]

Hey @nivasan1 should we review this? I am asking because you closed it.

Hi! Yes, this PR is ready for review, please let me know if you all would like more context on mev-tendermint / why the alerts added are relevant. Thanks!

[itsciccio]

Have all tests passed?

[itsciccio]

Have you ran PANIC with docker-compose up --build -d? Did it run without errors?

[itsciccio]

Have you ran PANIC with docker-compose up --build -d? Did it run without errors?

Is the new alert configurable in the UI? (When setting a cosmos node, in the alerts configuration step, are the new alerts shown in the list, and are you able to be configure it (ex: change severity)?

[itsciccio]

Great work on this PR! Thank you for abiding by our code standards.

[itsciccio]

Okay, I just noticed that the data store is not updated to cater for these new metrics. Kindly have a look at the Cosmos Node Store code and amend it to cater for these new metrics being added.

The AlertStore might also need to be amended for the new alerts. Have a look at the codebase, although it might be catered for automatically.

[itsciccio]

Would be great if you can update the relevant docs

[nivasan1]

Have all tests passed?

Yes, I have also modified the testing suites to accomodate the newly added alerting logic

[nivasan1]

Have you ran PANIC with docker-compose up --build -d? Did it run without errors?

Is the new alert configurable in the UI? (When setting a cosmos node, in the alerts configuration step, are the new alerts shown in the list, and are you able to be configure it (ex: change severity)?

I have been able to run the alerter with both a mev-tendermint / non-mev-tendermint node, both the node_is_peered_with_sentinel and validator_is_peered_with_sentinel alerts are configurable in the panic UI. I have also tested that the regular alerts / new alerts were emitted at the expected times. Please let me know if there is anything else I should be looking into further

[dillu24]

unless there is anything else from @itsciccio side all there is left for this to be merged is the changes suggested above

[itsciccio]

Super! We can proceed with the merge. Thank you for resolving all the threads which I opened.

Will need to check something with the team prior to merge. But all okay from your end.

[itsciccio]

One last thing: Please update the changelog here, in the Unreleased section: https://github.com/SimplyVC/panic/blob/master/docs/CHANGE_LOG.md

Just so we can keep track of these community contributions.