Can't dismiss revert dialog with Esc

SimpsonGSD / P4EditVS

Simple, lightweight Visual Studio plugin to run various Perforce commands on files, such as checkout and revert. Includes optional auto-checkout feature.

https://marketplace.visualstudio.com/items?itemName=ScottSimpson.p4editvs

MIT License

32 stars 8 forks source link

Can't dismiss revert dialog with Esc #27

Closed tom-seddon closed 2 years ago

tom-seddon commented 2 years ago

This message box (and in fact any dialogs like it...) should have whatever flags added that mean the user can press Esc to get back to where they were, with no action taken.

No PR yet, but this is on my to do list.

--Tom

P.S. Visual Studio gets this wrong too!

tom-seddon commented 2 years ago

Had a quick look at this, and it seems the Yes/No dialog just doesn't support Esc. Esc = Cancel, and if there's no Cancel button, it does nothing. Could reword the dialogs so they make sense as OK/CAncel? - probably easier just to leave it.