search

SimpsonGSD / P4EditVS

Simple, lightweight Visual Studio plugin to run various Perforce commands on files, such as checkout and revert. Includes optional auto-checkout feature.
https://marketplace.visualstudio.com/items?itemName=ScottSimpson.p4editvs
MIT License
32 stars 8 forks source link

Check out .projitems when checking out a .shproj. #31

Closed tom-seddon closed 2 years ago

tom-seddon commented 2 years ago

Fix #30

SimpsonGSD commented 2 years ago

Is it worth a quick, does this file exist locally check before throwing it at P4?

I'm not as familiar with C#, so unsure how often, if ever, there won't also be a projitems file. If it's unexpected then happy to leave as is.

tom-seddon commented 2 years ago

There's already a file exists check as part of AddSelectedFile, so if it doesn't exist the request will just get ignored: https://github.com/SimpsonGSD/P4EditVS/blob/05aecb0095dd69d508a68ed08bd10b629a9737bf/P4EditVS/Commands.cs#L271

SimpsonGSD commented 2 years ago

You can tell I've not looked at the code for a while 😄

SimpsonGSD commented 2 years ago

Thanks for the change

SimpsonGSD commented 2 years ago

Is it worth a quick, does this file exist locally check before throwing it at P4? I'm not as familiar with C#, so unsure how often, if ever, there won't also be a projitems file?

On Mon, 3 Oct 2022, 18:20 Tom Seddon, @.***> wrote:

Fix #30 https://github.com/SimpsonGSD/P4EditVS/issues/30

You can view, comment on, or merge this pull request online at:

https://github.com/SimpsonGSD/P4EditVS/pull/31 Commit Summary

File Changes

(3 files https://github.com/SimpsonGSD/P4EditVS/pull/31/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/SimpsonGSD/P4EditVS/pull/31, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWL2IY3HLCTU23FD2BW24DWBMIXNANCNFSM6AAAAAAQ3ZNZOY . You are receiving this because you are subscribed to this thread.Message ID: @.***>