SimpsonGSD / P4EditVS

Simple, lightweight Visual Studio plugin to run various Perforce commands on files, such as checkout and revert. Includes optional auto-checkout feature.
https://marketplace.visualstudio.com/items?itemName=ScottSimpson.p4editvs
MIT License
32 stars 8 forks source link

Open in P4V fails with P4V 2024.1 #39

Closed fmod-mathew closed 6 months ago

fmod-mathew commented 6 months ago

In P4V 2024.1 with "bug fix" #119251, they changed the command line for the Open in P4V functionality. Rather than p4vc -s <file name> you must now use p4vc workspacewindow -s <file name> or you get a popup error message.

One upside of fixing this is you can close #36 as this is the new behavior.

For completeness, here is the note from the P4V revision history:

119251 (Change #2555854)

'p4v -s', and 'p4v -t' now tells you to run 'p4vc workspacewindow -s', or 'p4vc
workspacewindow -t'. The workspacewindow provides the same functionality as
running P4V. If you run 'p4vc workspacewindow -s <filename>' and a
workspacewindow is already running connected to that client, it brings the
application to the foreground and selects that file in either the workspace or
depot tree instead of opening a second window.
SimpsonGSD commented 6 months ago

thanks for this, will look into it

SimpsonGSD commented 6 months ago

Please try v2.6.8 https://github.com/SimpsonGSD/P4EditVS/releases/tag/v2.6.8 You need to enable 2024.1 Open in P4V support in the options. I will push it to marketplace soon.

fmod-mathew commented 6 months ago

Thanks very much for the speedy turnaround, works great.

SimpsonGSD commented 6 months ago

Great, thanks for the update.