search

Simpsonpt / AppSecEzine

AppSec Ezine Public Repository.
1.06k stars 96 forks source link

Consistency #4

Closed xl-sec closed 11 months ago

xl-sec commented 11 months ago

Hi, first of -- massive thanks for a great ezine!

For a summer project (I'm making a RSS generator to feed a slack bot) I wanted to parse all historic ezines and ran across a number of inconsistency -- typos, missing labels etc. I split it into multiple commits for clarity, feel free to merge, squash or ignore :)

xl-sec commented 11 months ago

Arrgh sorry, didn't know that all the commits to the branch would be included in the pull request, only the ones up to 2d0a99b is relevant for consistency.

Simpsonpt commented 11 months ago

Wow, unexpected and fantastic! Thank you for this contribution. RSS was one of the most requested features. Thumbs up for the inconsistency fixes :)

The overall contribution looks excellent, although I am not "comfortable" with the workflows. Nevertheless, this deserves to be merged, and it is a great starting point for further improvements.

xl-sec commented 11 months ago

You're welcome :)

No worries, I wouldn't be comfortable with workflows from a random person on the internet either. Feel free to remove the workflows in this upstream repo and I'll keep them in mine. I'm happy to keep the RSS on my github, unless you want to host it yourself. (Do note that your current readme points to my repo)

Simpsonpt commented 11 months ago

I just moved your automation code to a testing branch, and yes, I saw the readme update, and it makes sense (at least for now). Thank you once again :)